Added a fix to make the module work inside a virtual environment on Windows#101
Added a fix to make the module work inside a virtual environment on Windows#101l0r3m1psum wants to merge 1 commit intopytorch:masterfrom
Conversation
…indows On Windows when trying to load the extension, after having compiled it and installed it in a virtual environnement, it failed to load the custom operator. I have traced this issue to a problem related to DLL loading paths. This change fixes this issue by adding the directory, in the virtual environment, where PyTorch's DLLs are stored, to the DLL search path of Python.
|
Hi @l0r3m1psum! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
On Windows when trying to load the extension, after having compiled it and installed it in a virtual environnement, it failed to load the custom operator. I have traced this issue to a problem related to DLL loading paths.
This change fixes this issue by adding the directory, in the virtual environment, where PyTorch's DLLs are stored, to the DLL search path of Python.